Code Review: What do you review in a peer code review?

Code Review: What do you review in a peer code review?
All changes made should be reviewed in a code review; however, it is normal to focus in on key areas. It is okay for the author to give some hints at something he wants the reviewer to specifically focus on.

Quote:
“We look at everything, but generally focus on the more interesting areas. What’s interesting? Whatever jumps out at us when we’re looking at the code, or anything the author specifically wants to focus on. Our goal isn’t necessarily to put a microscope to every single line of code.”
– Jeff Atwood

Application:
All changes means that all of the following should be reviewed: CSS, HTML, JavaScript, C#, config files, unit tests, and behavior tests. If you need some guidance as to what to look for in a code review, I would advise looking at the Coding Practices covered earlier in the Road to Excellence series.

References:
http://www.codinghorror.com/blog/2006/01/code-reviews-just-do-it.html

About Chris VanHoose

Principal Software Architect at CT Lien Solutions
This entry was posted in Software Architecture and tagged , . Bookmark the permalink.

Leave a Reply

Please log in using one of these methods to post your comment:

WordPress.com Logo

You are commenting using your WordPress.com account. Log Out /  Change )

Google+ photo

You are commenting using your Google+ account. Log Out /  Change )

Twitter picture

You are commenting using your Twitter account. Log Out /  Change )

Facebook photo

You are commenting using your Facebook account. Log Out /  Change )

Connecting to %s

This site uses Akismet to reduce spam. Learn how your comment data is processed.